Simplify variant effect prediction reverse strand handling#126
Merged
kathyxchen merged 7 commits intoFunctionLab:masterfrom Nov 19, 2019
Merged
Simplify variant effect prediction reverse strand handling#126kathyxchen merged 7 commits intoFunctionLab:masterfrom
kathyxchen merged 7 commits intoFunctionLab:masterfrom
Conversation
Collaborator
Author
|
Fixes #125 (documentation only update) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This is a refactoring change - the code originally used to incorporate variant effect prediction for the reverse strand was unwieldy and difficult to debug.
What does this implement/fix? Explain your changes.
Everything is applied to the forward sequence first and then we apply reverse complement afterwards.
What testing did you do to verify the changes in this PR?
Ran and compared the outputs for reverse strand variant effect prediction to verify that it still matched.