Remove chromosome/scaffold name mangling for bed/vcf files#137
Merged
evancofer merged 3 commits intoFunctionLab:masterfrom Feb 11, 2020
Merged
Remove chromosome/scaffold name mangling for bed/vcf files#137evancofer merged 3 commits intoFunctionLab:masterfrom
evancofer merged 3 commits intoFunctionLab:masterfrom
Conversation
Collaborator
|
Thanks @evancofer! Was thinking about whether to remove the |
Collaborator
Author
|
@kathyxchen This has been updated to include the suggested changes. |
kathyxchen
approved these changes
Feb 9, 2020
Collaborator
kathyxchen
left a comment
There was a problem hiding this comment.
LGTM after 1 adjustment (noted in my review comment) & all changes are tested for standard + nonstandard chromosome FASTA. Thank you!!
| if 'CHR' == chrom[:3]: | ||
| chrom = chrom.replace('CHR', 'chr') | ||
| elif "chr" not in chrom: | ||
| elif "chr" not in chrom and check_chr is True: |
Collaborator
There was a problem hiding this comment.
update to 'chr' not in chrom and check_chr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
Selene should no longer automatically add "chr" to the start of the chromosome/scaffold name for every record in a bed/vcf file.
What testing did you do to verify the changes in this PR?
Verified that specified changes did not cause existing prediction and VEP examples to fail.