Merged
Conversation
kathyxchen
requested changes
Apr 23, 2020
Collaborator
kathyxchen
left a comment
kathyxchen
left a comment
There was a problem hiding this comment.
Thanks @j-funk!! A couple minor comments, LGTM after those changes
| r.write_to_file() | ||
|
|
||
| def _pad_or_truncate_sequence(self, input_seq): | ||
| sequence = input_seq |
Collaborator
There was a problem hiding this comment.
remove this line, use directly _pad_or_truncate_sequence(self, sequence). thanks for the refactor, I like this helper function. :)
| input : str | ||
| A single sequence, or a path to the FASTA or BED file input. | ||
| output_dir : str, optional | ||
| Output directory to write the model predictions. If this is left |
Collaborator
There was a problem hiding this comment.
Add default to the description. (Default is None. Output directory to...) Maybe also clarify that FASTA and BED inputs require an output directory to be specified?
kathyxchen
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR modifies the
AnalyzeSequencesmember methodget_predictionsto enable the submission of python strings as a raw sequence to retrieve predictions as Python object.Previously predictions for sequences could only be requested using FASTA files.
What testing did you do to verify the changes in this PR?
I successfully retrieved an array of predictions using both a raw sequence of 1000 length, and using the same sequence formatted as a FASTA file. The resulting predictions were the same in both cases.