Additional seeding for reproducibility#173
Merged
kathyxchen merged 1 commit intoFunctionLab:masterfrom Aug 31, 2021
Merged
Conversation
Collaborator
|
LGTM, thank you @rfriedman22 for your work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes issues with reproducibility when random seed is provided as discussed in the Google group
What does this implement/fix? Explain your changes.
Seed the Python and Numpy random number generator with the same seed used for Torch, and set torch to use deterministic algorithms.
What testing did you do to verify the changes in this PR?
Added these lines to a CLI script and ran Selene twice with the same input and same seed, and verified the output of the training loss and validation performance metrics was identical.