Freeplay DJ bops to BPM

[KutikiPlayz]

Implements #2760

The Freeplay DJ idle animation just looped before, now it plays with the bpm of whatever song is selected.
Also the backingCard had stuff to do on beatHit but the Conductor wasn't being updated so that works as well now.

Before:

before.mp4

After:

after.mp4

[Hundrec]

This is super cool and I want to see it in the game!
I also really hope it doesn't break anything

[JackXson-Real]

This is 100% needed

[amyspark-ng]

oh this is very cool...
fixes #2760

[KutikiPlayz]

thank you, I tried searching freeplay dj but didn't find anything under that specifically so yeah

[Hundrec]

I wonder why this doesn't show as linked to #2760 after your edit, at least for me

[amyspark-ng]

thank you, I tried searching freeplay dj but didn't find anything under that specifically so yeah

i didn't know it was called dj back then lol!

[amyspark-ng]

I wonder why this doesn't show as linked to #2760 after your edit, at least for me

not sure, if this is merged and it does link that issue will the issue close when this gets merged?

[Hundrec]

I'm curious to find out! I'll let you know if that happens with any of my PRs in funkin.assets

[KutikiPlayz]

maybe it doesn't like it if I try to add it in an edit

[Hundrec]

Weird, I think I've edited an issue in before, and that was from funkin.assets

[NotHyper-474]

I wonder why this doesn't show as linked to #2760 after your edit, at least for me

It only links it if the base branch is the default branch (main), but changing from the default branch to another doesn't unlink it.

[ninjamuffin99]

might make a change where pico doesn't bop / spin to beat, or other lil cleanings, but generally this looks yummy and I think we had something like this in progress but swapped over to other tasks, very epic will poke at this :)

[AbnormalPoof]

might make a change where pico doesn't bop / spin to beat

I recommend adding a boolean to the Player data (somewhere in freeplayDJ like danceToBeat?) so it isn't hardcoded to just Pico!

[KutikiPlayz]

I was thinking of doing a -hold animation type thing so that the records can still spin if the bpm is too slow, but that requires stuff on the assets side and idk if I can do that easily myself since it's not a sparrow sprite, besides the code for using a -hold anim once the main one finishes

[KutikiPlayz]

I recommend adding a boolean to the Player data (somewhere in freeplayDJ like danceToBeat?) so it isn't hardcoded to just Pico!

I can do that

[KutikiPlayz]

alright it's there now
it's gonna say there's a bunch of other changes in assets but that's cuz I think they're doing other stuff in develop that aren't on the main assets branch

[Cartridge-Man]

Ngl this is pretty cool looking, hope this can be tested to make sure nothing breaks and then eventually maybe will get merged in the next update

[KutikiPlayz]

all better 👍

[AbnormalPoof]

Please resolve the merge conflicts on this PR within 90 days.

[Hundrec]

This was a cool concept, but Dave says that in practice the DJ took away too much focus from the song capsules.