[ENHANCEMENT] Character Singing Overrides And No anim Notes - #4036
Conversation
|
"no animation" note is useful !! though for the anim override i feel like a better solution would be to add an optional |
|
|
note kind params is an array of param objects for custom options the best solution imo would be like |
|
ALRIGHT! now this system uses the existing notekind manager to grab the scripted notekind. if its null itl just do the default singing. but if its not itl check for a no anim variable that must be set in the script. as well as if a suffix has been set otherwise it just plays default sing anims. |
|
Please change the base branch to Side note: I do not recommend using the default branch |
Alrighty! It has been changed!! Thank you for letting me know for the future |
AbnormalPoof
left a comment
There was a problem hiding this comment.
A lot of the comments here are messy and need cleanup. I also noticed some weird changes to the code.
i believe i did all the needed edits here! if any more pop up ill be sure to fix! |
|
im so surprised this is a honor thanks yall |
This pr allows for scripts to easily override the base sing anim function with a singOveride variable. it also adds a no animation note to the chart editor!