Skip to content

[ENHANCEMENT] Character Singing Overrides And No anim Notes - #4036

Merged
Hundrec merged 1 commit into
FunkinCrew:dummy/develop-v0.7.5from
Kuru-B0t-2:main
Sep 25, 2025
Merged

[ENHANCEMENT] Character Singing Overrides And No anim Notes#4036
Hundrec merged 1 commit into
FunkinCrew:dummy/develop-v0.7.5from
Kuru-B0t-2:main

Conversation

@Eviethecoder

Copy link
Copy Markdown
Contributor

This pr allows for scripts to easily override the base sing anim function with a singOveride variable. it also adds a no animation note to the chart editor!

@github-actions github-actions Bot added pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels Jan 25, 2025
@Eviethecoder Eviethecoder changed the title Character Singing Overrides And No anim Notes [ENHANCEMENT] Character Singing Overrides And No anim Notes Jan 25, 2025
@lunacynne

lunacynne commented Jan 25, 2025

Copy link
Copy Markdown
Contributor

"no animation" note is useful !!

though for the anim override i feel like a better solution would be to add an optional noAnimation and suffix property to the notekind
that way the anim override can be determined with just the note kind script rather than the script also having to mess with and correctly keep track of the variable in the characters so it doesnt accidentally also disable sing anims for other note kinds...

@Eviethecoder

Copy link
Copy Markdown
Contributor Author

"no animation" note is useful !!

though for the anim override i feel like a better solution would be to add an optional noAnimation and suffix property to the notekind that way the anim override can be determined with just the note kind script rather than the script also having to mess with and correctly keep track of the variable in the characters so it doesnt accidentally also disable sing anims for other note kinds...
YO THAT MAKES SENSE!!!! ill add that quickly here soon thanks for the idea

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels Jan 25, 2025
@lunacynne

Copy link
Copy Markdown
Contributor

note kind params is an array of param objects for custom options

the best solution imo would be like
instead of them being part of the param structure they should be instead be just noAnimation:Bool and ?suffix:String variables in the note kind class
and then in the hit note function -> check note kind in data -> get note kind from registry if it exists -> check those 2 variables -> handle animation logic accordingly

@github-actions github-actions Bot added size: large A large pull request with more than 100 changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Feb 6, 2025
@Eviethecoder

Copy link
Copy Markdown
Contributor Author

ALRIGHT! now this system uses the existing notekind manager to grab the scripted notekind. if its null itl just do the default singing. but if its not itl check for a no anim variable that must be set in the script. as well as if a suffix has been set otherwise it just plays default sing anims.

Comment thread source/funkin/play/character/BaseCharacter.hx Outdated
@AbnormalPoof

AbnormalPoof commented Feb 10, 2025

Copy link
Copy Markdown
Member

Please change the base branch to develop.

Side note: I do not recommend using the default branch main for pull requests since it's considered an anti-pattern. Just something to keep in mind in the future.

@AbnormalPoof AbnormalPoof added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Feb 10, 2025
@Eviethecoder
Eviethecoder changed the base branch from main to develop February 10, 2025 13:18
@Eviethecoder

Copy link
Copy Markdown
Contributor Author

Please change the base branch to develop.

Side note: I do not recommend using the default branch main for pull requests since it's considered an anti-pattern. Just something to keep in mind in the future.

Alrighty! It has been changed!! Thank you for letting me know for the future

@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 10, 2025
@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label Apr 5, 2025

@AbnormalPoof AbnormalPoof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the comments here are messy and need cleanup. I also noticed some weird changes to the code.

Comment thread source/funkin/play/character/BaseCharacter.hx
Comment thread source/funkin/play/character/BaseCharacter.hx Outdated
Comment thread source/funkin/play/character/BaseCharacter.hx
Comment thread source/funkin/play/character/BaseCharacter.hx
Comment thread source/funkin/play/character/BaseCharacter.hx
Comment thread source/funkin/play/notes/notekind/NoteKind.hx
Comment thread source/funkin/play/notes/notekind/NoteKind.hx Outdated
Comment thread source/funkin/play/notes/notekind/NoteKindManager.hx
Comment thread source/funkin/play/notes/notekind/NoteKindManager.hx Outdated
Comment thread source/funkin/ui/debug/charting/util/ChartEditorDropdowns.hx Outdated
@AbnormalPoof AbnormalPoof added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Apr 27, 2025
@github-actions github-actions Bot added size: medium A medium pull request with 100 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Apr 27, 2025
@Eviethecoder

Eviethecoder commented Apr 27, 2025

Copy link
Copy Markdown
Contributor Author

A lot of the comments here are messy and need cleanup. I also noticed some weird changes to the code.

i believe i did all the needed edits here! if any more pop up ill be sure to fix!

@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Apr 27, 2025
Comment thread source/funkin/play/notes/notekind/NoteKindManager.hx Outdated
@EliteMasterEric EliteMasterEric added size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels May 14, 2025
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Aug 14, 2025
@Hundrec
Hundrec changed the base branch from develop to dummy/develop-v0.7.5 September 25, 2025 08:49
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Sep 25, 2025
@Hundrec Hundrec added this to the 0.7.6 milestone Sep 25, 2025
@Hundrec
Hundrec removed the request for review from AbnormalPoof September 25, 2025 08:49
@Hundrec
Hundrec merged commit 0a581c1 into FunkinCrew:dummy/develop-v0.7.5 Sep 25, 2025
6 checks passed
@Eviethecoder

Copy link
Copy Markdown
Contributor Author

im so surprised this is a honor thanks yall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

5 participants