[ENHANCEMENT + BUGFIX] Soft coding and improvement for visualizers - #4063
Draft
MidyGamy wants to merge 1 commit into
Draft
[ENHANCEMENT + BUGFIX] Soft coding and improvement for visualizers#4063MidyGamy wants to merge 1 commit into
MidyGamy wants to merge 1 commit into
Conversation
Hundrec
added
type: enhancement
Contributor
Author
|
Ok wait before including it, a small issue in the web version where only the cutscene music is seen on Abot. (converting to draft) |
MidyGamy
marked this pull request as draft
January 29, 2025 23:08
MidyGamy
marked this pull request as ready for review
January 30, 2025 01:39
Contributor
Author
|
Wait... Shouldn't this PR have the |
Member
|
Sure, we can do that |
MidyGamy
changed the title
MidyGamy
changed the title
Contributor
Author
|
A little showcase of it! |
Member
|
This is actually such a cool detail! |
Hundrec
added
status: needs revision
Member
|
Please resolve the merge conflicts! |
MidyGamy
marked this pull request as draft
April 15, 2025 17:40
MidyGamy
force-pushed
the
soft-code-visualizers
branch
from
April 15, 2025 17:57
1675700 to
880a056
Compare
MidyGamy
force-pushed
the
soft-code-visualizers
branch
from
April 15, 2025 18:01
2ab8460 to
01daaff
Compare
Hundrec
removed
the
status: needs revision
EliteMasterEric
force-pushed
the
develop
branch
from
April 28, 2025 20:20
0c674ac to
b7761d4
Compare
Contributor
|
Why is this still a draft after the merge conflicts were fixed? |
Contributor
Author
|
Cause the update came, so it conflicts again |
EliteMasterEric
added
size: large
Hundrec
force-pushed
the
develop
branch
2 times, most recently
from
February 1, 2026 03:24
3829dcb to
5805c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a retake of #2994
This make visualize soft modable so nene.hxc now use it (making ABotVis.hx useless)
It also allows the visualizers to track different sounds than FlxG.sound.music, and support for cutscenes musics in Darnell and the Pico mixes of week 3.
It also fixes: