Expand the chart editor's user guide

[MAZ12211]

• Bumps up the dialogue size of the user guide
• Adds a Patterns page which contains a way to describe patterns in text-form and lists all common patterns from most to least common in the FNF space.
• Adds a Terms page which contains must-know terms (note, chord, BPM, offset) and general terms (Pitch relevance, Layering, Sightread).
• Adds a Tips page which contains advice on how to make a good chart

All references are listed in the file
Thanks to Friday Night Moddin's discord server (#charting-problems) and Etterna's discord server for feedback

Funkin_C3iFCEoywr.mp4

This is my first time using HaxeUI, so expect wacky XML code
It may have some stuff missing like how to get feedback or what FNFC means or a UI rundown of the editor, but I didn't have enough time to include them as I don't know a whole lot about them and didn't want to invest a lot of time on it.

[EliteMasterEric]

I have a few changes, and our other reviewers might have some too, but overall this is excellent! I love the in-line images.

It may have some stuff missing like what FNFC means

.fnfc is short for Friday Night Funkin' Chart. We might have other extensions in the future like .fnfmod or something

or a UI rundown of the editor

This was actually the main intent for the Help menu, but this is nice to have as well.

[EliteMasterEric]

We'll probably have our charting team proofread and tweak these tips to help match their style of charting (but that'll be after merge).

[Lasercar]

You might want to use this chance to update the hotkeys too with the ones that are currently missing (/ will be added by PRs).

Also, I wouldn't have made these changes on the main branch, as now you'll be waiting for this to be merged before you can fix/change anything else in the assets.

[MAZ12211]

Also, I wouldn't have made these changes on the main branch, as now you'll be waiting for this to be merged before you can fix/change anything else in the assets.

Oh yeah I forgot doing that in my fork, don't know what to do at this point lol

You might want to use this chance to update the hotkeys too with the ones that are currently missing (/ will be added by PRs).

What missing hotkeys?

[Lasercar]

Also, I wouldn't have made these changes on the main branch, as now you'll be waiting for this to be merged before you can fix/change anything else in the assets.

Oh yeah I forgot doing that in my fork, don't know what to do at this point lol

You can create a branch based off your main (basically copying/saving the changes), and then reset it (delete it, and then create it again and base it off the upstream main branch, make sure the other new branch has the changes first!), but not yet - doing that now will close this issue and whatnot, so you'll still have to wait before you can do that, unless eric would be ok with this being closed/redone because it's on the main branch?

You might want to use this chance to update the hotkeys too with the ones that are currently missing (/ will be added by PRs).

What missing hotkeys?

Hmm, I though the middle mouse click one wasn't in there, but it is, so it's only just the PR ones that are missing, so don't worry about that.

Wait, I think the shift + right click on a note isn't mentioned in it?

That, and the middle mouse click one is wrong, is should be middle click + mouse move OR arrows/mouse wheel.

And, there's a few edit ones that aren't in it too:

Paste unsnapped, flip notes, select all events (select all is actually select all notes)

And also, right clicking on a hold of a hold note removes it.

[EliteMasterEric]

I went to review this but all the images from the video are missing! They're not part of the PR either.

[MAZ12211]

OH Right! I forgot!

[MAZ12211]

@EliteMasterEric Should work now 👍

[Lasercar]

Pro tip, use github desktop so you can do all that with one commit/change, rather than 9.

[MAZ12211]

Pro tip, use github desktop so you can do all that with one commit/change, rather than 9.

I did it in the browser and vscode in the browser because I don't actually have the fork stored in my hard drive (slow WIFI with cloning large repos)

[Lasercar]

Pro tip, use github desktop so you can do all that with one commit/change, rather than 9.

I did it in the browser and vscode in the browser because I don't actually have the fork stored in my hard drive (slow WIFI with cloning large repos)

OH, I see. Carry on then.

[Lasercar]

This PR needs a rebase. Click the dropdown you see next to the conflicts bit below, swap it to rebase and then click the button.

[MAZ12211]

There's no dropdown on my end, but I synced my fork just now

[AbnormalPoof]

There's 2 leftover commits from the old main branch

[MAZ12211]

What do I do about that?
Genuinely asking

[MAZ12211]

Fork got synced

[Lasercar]

Fork got synced

Well yes, but actually no. It still has those two unnecessary commits. You need to rebase merge it still.

Next to the button for the update branch, you'll see a dropdown - swap it to rebase and click it.

[MAZ12211]

@Lasercar
I genuinely can't find it on my end

[Hundrec]

Lasercar was referring to a button on the bottom of this PR page, but that option might not show up here either.
So you see anything on this page?

[MAZ12211]

@Hundrec Nope

[Hundrec]

Cool, then you can leave this PR like this for now. Thanks for writing this up!

[AbnormalPoof]

Cleaned up the history on this one

[AbnormalPoof]

THERE'S NO IMAGES AAAAAAAAHHHHHHHHHHHHHHHHHHHHHHHHHHH!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! THE WORLD IS ENDING

[MAZ12211]

Wtf
Hold on

[MAZ12211]

If this gets in V0.7.4, then I should mention that I just did another read through for the user guide today, and it needs proofreading at some point after merge (or now after review if you want)