Conversation
BriDavidson
requested review from
JakeLo123,
david-chalk,
dmackinn and
michaelyons
JakeLo123
approved these changes
Apr 2, 2024
dmackinn
approved these changes
Apr 2, 2024
BriDavidson
deleted the
17-add-redirect-handling-to-login-or-register-cta
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
Adds handling to "log in" to redirect users to log in flow
Adds handling to "create a new account" to redirect users to register flow
We are switching from using an anchor to using a button here for accessibility purposes. There should be no visible changes to the UI and clicking the log in or create a new account buttons on the home page should respectively redirect to log in and register flow.
#17
Pre-Merge Checklist (if applicable)