OpenAI exception handling for biological risk - #478
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds fallback handling for a newly observed OpenAI BadRequestError message related to “possible biological risk”, ensuring the retry/fallback logic treats it as a fall-over case and adding a regression test for it.
Changes:
- Extend
should_fallback’s message-pattern matching to include OpenAI’s “possible biological risk” 400 message. - Add a unit test verifying that this message triggers fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/lmi/src/lmi/retry.py | Adds the new message pattern used by should_fallback to decide when to fall over on BadRequestError. |
| packages/lmi/tests/test_retry.py | Adds a regression test to ensure the biological-risk BadRequestError falls back. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amascolo
force-pushed
the
fix/openai-biological-risk
branch
from
August 4, 2026 21:59
d63a914 to
2e43c6b
Compare
Eddie-MG
approved these changes
Aug 4, 2026
Collaborator
Author
|
Actions are failing due to broken/flaky CI, unrelated to this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/edisonscientific/issue/AAI-536/