DataArray throws a proper exception if range dim with empty ticks is created#437
Merged
gicmo merged 4 commits intoG-Node:masterfrom Jan 16, 2015
Merged
DataArray throws a proper exception if range dim with empty ticks is created#437gicmo merged 4 commits intoG-Node:masterfrom
gicmo merged 4 commits intoG-Node:masterfrom
Conversation
gicmo
added a commit
that referenced
this pull request
Jan 16, 2015
DataArray throws a proper exception if range dim with empty ticks is created LGTM
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Jan 20, 2015
DataArray throws a proper exception if range dim with empty ticks is created LGTM
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Oct 18, 2015
Not a size_t. Part of gh issue G-Node#437
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Oct 18, 2015
Not a size_t. Part of gh issue G-Node#437
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Oct 19, 2015
More of gh issue G-Node#437
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Oct 19, 2015
More of gh issue G-Node#437. Will it ever stop...
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Oct 19, 2015
Still gh issue G-Node#437
gicmo
added a commit
to gicmo/nix
that referenced
this pull request
Oct 19, 2015
Still part of gh issue G-Node#437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, DataArray::appendRangeDimension(ticks) with empty ticks vector led to an HDF5 Exception which was shown as unidentifiable C++ Exception in nixpy, actually providing no information about the real cause.