H5::BaseHDF5: change ref-count behaviour of hid_t ctor#459
Merged
stoewer merged 12 commits intoG-Node:masterfrom Feb 4, 2015
Merged
H5::BaseHDF5: change ref-count behaviour of hid_t ctor#459stoewer merged 12 commits intoG-Node:masterfrom
stoewer merged 12 commits intoG-Node:masterfrom
Conversation
For the inlining!
As in BaseHDF5
Adjusted all code paths + tests for that change
stoewer
added a commit
that referenced
this pull request
Feb 4, 2015
H5::BaseHDF5: change ref-count behaviour of hid_t ctor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseHDF5::BaseHDF5(hid_t)used to do ainc(), i.e making acopy of the object. It now takes over ownership by not doing that
inc(). This allows code likeGroup g = H5Gopen()instead ofthe longer version
hid_t o = H5Gopen(); Group g = o; H5Idec_ref(o);.