fix max_depth pass through and extend tests#696
Merged
mpsonntag merged 3 commits intoG-Node:masterfrom Sep 17, 2017
Merged
Conversation
mpsonntag
approved these changes
Sep 7, 2017
achilleas-k
approved these changes
Sep 7, 2017
gicmo
approved these changes
Sep 7, 2017
src/File.cpp
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
Member
Author
There was a problem hiding this comment.
ups will kill it in case we decide to add the compression flag to File, if you don't mind
reduce max_depth while passing it down
jgrewe
force-pushed
the
find_section
branch
from
85fea12 to
f26c7d0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #689