refactor: move LSP plugin contracts to owner crates - #1359
Merged
Conversation
limityan
force-pushed
the
yanzhn/core-pr-d-extension-host
branch
from
June 30, 2026 09:44
e68006d to
a14a844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-coretobitfun-core-types, while preserving the legacybitfun_core::service::lsp::typesimport path.bitfun-services-core; keep plugin package IO and process lifecycle in the core compatibility adapter.Risk and compatibility
bitfun_core::service::lspremain available via compatibility re-exports.Validation
cargo test -p bitfun-core-typescargo test -p bitfun-services-corecargo test -p bitfun-services-core --test lsp_plugin_registry_contractscargo check -p bitfun-core --no-default-featurescargo check -p bitfun-core --features product-fullcargo check -p bitfun-desktopcargo check --workspacecargo metadata --no-deps --format-version 1node scripts/check-core-boundaries.mjsnode --test scripts/check-core-boundaries.test.mjspnpm run check:repo-hygienegit diff --checkKnown warning: Rust checks still show existing
rmcpdeprecation warnings inservices-integrations/src/mcp/protocol/client_info.rs.