feat(review): add portable subject composition contracts - #1518
Merged
Conversation
limityan
force-pushed
the
yanzhn/review-planner-foundation
branch
from
July 12, 2026 16:05
f08a527 to
10f0ded
Compare
limityan
marked this pull request as ready for review
July 12, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a small portable contract for composing review subjects without introducing a separate model-planning phase.
modeandrole); review questions, output shape, tool choice, and execution strategy remain owned by the main review model.Deliberate exclusions
Validation
cargo test -p bitfun-product-domains --features product-full --test review_policy -- --nocapture(12 passed)cargo test -p bitfun-product-domains --no-default-features -- --nocapture(passed)cargo check -p bitfun-product-domains --features product-full(passed)cargo check --workspace(passed; existing repository warnings only)git diff --check upstream/main...HEAD(passed)node scripts/check-core-boundaries.mjsstill reports the existingreview-platformoptional dependency ownership baseline forsha2andwindows; this PR does not touch that integration feature or Cargo manifest.Review focus
Please verify that deterministic inference remains limited to explicit user intent, ambiguous scenarios remain model-owned, and the public contract bounds do not narrow supported review target types.