refactor: reduce private Rust lint backlog - #1521
Merged
limityan merged 1 commit intoJul 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the current non-blocking Clippy backlog pass for private Rust internals while preserving public API and product behavior.
allow/expectexceptions and does not change CI enforcementDeliberately retained backlog
Four private
too_many_argumentsdiagnostics remain: three coordinator lifecycle helpers and one ACP session helper. Safe cleanup would require broader fixture or lifecycle restructuring, so they remain non-blocking rather than expanding this PR or weakening lint policy. Existing public-family and unsafe-related warning backlogs are unchanged.Risk review
Two independent adversarial reviews covered architecture/concurrency/performance and product/API compatibility. Both concluded MERGE with no actionable findings. The review specifically checked ownership and evaluation order, async and cancellation sequencing, lock scope, allocation/clone behavior, FFI layout and ABI, error propagation, public compatibility, remote/OpenCode/ACP behavior, and test fidelity.
Verification
cargo clippy --workspace --all-targetscargo test -p bitfun-core --lib --quiet(981 passed, 1 ignored)cargo test -p bitfun-desktop --lib --quiet(94 passed)cargo test -p bitfun-agent-runtime --all-targets --quietcargo test -p bitfun-agent-stream --all-targets --quiet(57 passed)cargo test -p bitfun-services-core --lib --quiet(73 passed)pnpm run check:repo-hygieneThe remaining warnings are pre-existing, explicitly outside this pass, and remain non-blocking.