Skip to content

fix(ci): restore boundary and Rust checks #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limityan merged 1 commit into from
Jul 13, 2026
Merged

fix(ci): restore boundary and Rust checks #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ jobs:
- name: Check repository hygiene
run: pnpm run check:repo-hygiene

- name: Check core boundaries
run: node --test scripts/check-core-boundaries.test.mjs

- name: Install dependencies
run: pnpm install --frozen-lockfile

Expand Down
4 changes: 2 additions & 2 deletions scripts/core-boundaries/rules/feature-rules.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const optionalDependencyFeatureOwnerRules = [
{ depName: 'rustls', ownerFeatures: ['remote-connect'] },
{ depName: 'rustls-native-certs', ownerFeatures: ['remote-connect'] },
{ depName: 'schannel', ownerFeatures: ['remote-connect'] },
{ depName: 'sha2', ownerFeatures: ['canvas-runtime', 'plugin-source', 'remote-connect', 'remote-ssh'] },
{ depName: 'sha2', ownerFeatures: ['canvas-runtime', 'plugin-source', 'remote-connect', 'remote-ssh', 'review-platform'] },
{ depName: 'shellexpand', ownerFeatures: ['remote-ssh-concrete'] },
{ depName: 'sse-stream', ownerFeatures: ['mcp'] },
{ depName: 'ssh_config', ownerFeatures: ['remote-ssh-concrete', 'ssh_config'] },
Expand All @@ -97,7 +97,7 @@ export const optionalDependencyFeatureOwnerRules = [
{ depName: 'urlencoding', ownerFeatures: ['canvas-runtime', 'remote-connect', 'review-platform'] },
{ depName: 'uuid', ownerFeatures: ['canvas-runtime', 'debug-log', 'miniapp-runtime', 'plugin-source', 'remote-connect', 'remote-ssh-concrete'] },
{ depName: 'which', ownerFeatures: ['miniapp-runtime', 'remote-connect', 'workspace-search'] },
{ depName: 'windows', ownerFeatures: ['plugin-source'] },
{ depName: 'windows', ownerFeatures: ['plugin-source', 'review-platform'] },
{ depName: 'x25519-dalek', ownerFeatures: ['remote-connect'] },
],
},
Expand Down
8 changes: 8 additions & 0 deletions scripts/core-boundaries/self-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,14 @@ export function runManifestParserSelfTest({
throw new Error(`services-integrations plugin-source must own optional dependency ${dep}`);
}
}
for (const dep of ['sha2', 'windows']) {
const owner = servicesOptionalOwnerRule?.dependencies.find(
(dependency) => dependency.depName === dep,
);
if (!owner?.ownerFeatures.includes('review-platform')) {
throw new Error(`services-integrations review-platform must own optional dependency ${dep}`);
}
}
const productDomainsOptionalOwnerRule = optionalDependencyFeatureOwnerRules.find(
(rule) => rule.crateName === 'product-domains',
);
Expand Down
4 changes: 2 additions & 2 deletions src/crates/services/services-integrations/src/mcp/protocol/transport_remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ impl StreamableHttpClient for BitFunStreamableHttpClient {
}
}

let event_stream = SseStream::from_bytes_stream(response.bytes_stream()).boxed();
let event_stream = SseStream::from_byte_stream(response.bytes_stream()).boxed();
Ok(event_stream)
}

Expand Down Expand Up @@ -303,7 +303,7 @@ impl StreamableHttpClient for BitFunStreamableHttpClient {

match content_type.as_deref() {
Some(ct) if ct.as_bytes().starts_with(EVENT_STREAM_MIME_TYPE.as_bytes()) => {
let event_stream = SseStream::from_bytes_stream(response.bytes_stream()).boxed();
let event_stream = SseStream::from_byte_stream(response.bytes_stream()).boxed();
Ok(StreamableHttpPostResponse::Sse(event_stream, session_id))
}
Some(ct) if ct.as_bytes().starts_with(JSON_MIME_TYPE.as_bytes()) => {
Expand Down
Loading