fix(plugins): clean residual activation state#1536
Merged
limityan merged 1 commit intoJul 14, 2026
Conversation
0d8057a to
f40e43b
Compare
f40e43b to
5a85409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Behavior and compatibility
Verification
cargo +nightly test -p bitfun-product-domains --test plugin_source_contracts --features plugin-source- 16 passedcargo +nightly test -p bitfun-services-integrations --no-default-features --features plugin-source plugin_source --lib- 60 passedcargo +nightly test -p bitfun-core --features product-full plugin_runtime::tests- 5 passedcargo +nightly test -p bitfun-cli --test plugin_source_cli- 4 passedcargo +nightly test -p bitfun-opencode-adapter --test opencode_source_adapter- 18 passednode scripts/check-core-boundaries.mjsBITFUN_BOUNDARY_CHECK_SELF_TEST=1 node scripts/check-core-boundaries.mjspnpm run check:repo-hygienecargo +nightly check --workspace --exclude bitfun-desktopgit diff --checkThe full workspace check reaches the desktop Tauri build script and requires the generated
src/mobile-web/distdirectory, which is not present in this clean worktree. The workspace check excludingbitfun-desktoppassed with existing warnings in untouched WebDriver and MCP code.Review
Two fresh, isolated reviewers performed architecture/code and product/documentation reviews. Their findings on same-ID replacement classification, structured diagnostics, persistence retry guidance, second-stage reconciliation durability, and stale-epoch handling under incomplete scans were fixed. Both final re-reviews reported no blocking or high-priority findings.