Skip to content

fix(acp): deduplicate startup and record lifecycle notifications - #1651

Merged
wgqqqqq merged 2 commits into
GCWing:mainfrom
wgqqqqq:fix/acp-session-startup-notifications
Jul 21, 2026
Merged

fix(acp): deduplicate startup and record lifecycle notifications#1651
wgqqqqq merged 2 commits into
GCWing:mainfrom
wgqqqqq:fix/acp-session-startup-notifications

Conversation

@wgqqqqq

@wgqqqqq wgqqqqq commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • atomically claim ACP client startup so concurrent option and command requests share one connection
  • replace the ACP session recovery overlay with ordinary notification-center history records for starting, success, and failure
  • propagate the actual lifecycle outcome and remove the duplicate ACP error toast
  • cover notification stack filtering and update startup performance selectors
  • stabilize the multiline CLI PTY contract by using a sentinel that Ratatui differential rendering emits contiguously

Verification

  • cargo test --locked -p bitfun-cli -p bitfun-acp -p bitfun-agent-runtime
  • cargo check --workspace
  • pnpm run type-check:web
  • pnpm --dir src/web-ui run test:run src/shared/notification-system/components/NotificationContainer.test.tsx
  • pnpm run i18n:audit
  • git diff --check upstream/main...HEAD

@wgqqqqq
wgqqqqq merged commit a9eab24 into GCWing:main Jul 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant