feat(remote-ssh): complete multi-hop and container workspaces#1742
Merged
Conversation
bobleer
force-pushed
the
bob/complete-remote-workspaces
branch
from
July 24, 2026 09:43
3c99050 to
9419cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1725.
Autosshd probing with Docker Exec fallback, TTY/non-TTY execution, and binary-safe atomic file transfers with cancellationCompatibility
Existing serialized connection/workspace records remain loadable through serde defaults and legacy auth deserialization. Startup does not prune an existing workspace when its connection needs credentials or is temporarily unavailable.
Autois re-probed on reconnect, while the original saved configuration is retained.Normal existing mirror/session path mappings are unchanged. Safe legacy dot-segment paths keep resolving to their previous effective mirror directories, while paths that would escape the mirror root are contained. Previously unsafe or unrepresentable recursive-transfer entries now fail explicitly instead of being silently skipped, overwritten, followed outside the selected tree, or mapped through host-specific path semantics.
Legacy local-Docker profiles with an empty password placeholder continue to load and connect without a password-vault entry. Docker process supervision also degrades to the previous transport-level cancellation behavior when a read-only container filesystem cannot create its optional PID tracking file, so supervision does not become a new runtime prerequisite after upgrade.
Verification
cargo check --workspacecargo check -p bitfun-desktopcargo test -p bitfun-services-integrations --features remote-ssh,remote-ssh-concrete,workspace-search remote_sshcargo test -p bitfun-services-integrations --features remote-ssh-concrete remote_ssh --libcargo test -p bitfun-services-integrations --features remote-ssh,remote-ssh-concrete,workspace-search --test remote_ssh_contractscargo test -p bitfun-services-integrations --features remote-ssh-concrete --test remote_ssh_contractscargo test -p bitfun-services-integrations --features remote-ssh --test remote_ssh_disabled_contractscargo test -p bitfun-desktop remote_workspace_policy --libcargo test -p bitfun-desktop api::ssh_api::tests --libnode --test scripts/check-core-boundaries.test.mjspnpm run type-check:webpnpm run lint:webpnpm --dir src/web-ui run test:run src/features/ssh-remote/SSHRemoteProvider.test.tsx src/features/ssh-remote/remoteWorkspaceReconnect.test.tspnpm run i18n:auditpnpm run theme:color-audit:allpnpm run check:repo-hygienepnpm run check:github-config