Skip to content

fix(permission): honor full access for Bash commands#1753

Merged
wsp1911 merged 1 commit into
GCWing:mainfrom
wsp1911:dev2
Jul 25, 2026
Merged

fix(permission): honor full access for Bash commands#1753
wsp1911 merged 1 commit into
GCWing:mainfrom
wsp1911:dev2

Conversation

@wsp1911

@wsp1911 wsp1911 commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix Bash tools falling back to confirmation when the global permission mode is Full access.
  • Preserve exact-command matching for custom Bash allow rules.
  • Add a regression test for the Full access Bash baseline.

Fixes #

Type and Areas

Type:

Regression fix

Areas:

Rust core

Motivation / Impact

Full access resolves to a */* -> Allow baseline, but the Bash-specific matcher previously ignored that rule and fell back to Ask. Bash commands now honor Full access while custom wildcard Bash allow rules remain non-authorizing for compound commands.

Verification

  • cargo check -p bitfun-core --features product-full
  • cargo test -p bitfun-core --features product-full --lib full_access_baseline_allows_bash_commands
  • Verified in the desktop development build: Full access resolved Bash, edit, read, and external-directory actions as Allow without a permission prompt.

Reviewer Notes

  • No migration or user-facing string changes.
  • The special case only recognizes the global */* -> Allow baseline; custom Bash Allow rules still require an exact command match.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

- Recognize the full-access wildcard allow in Bash permission matching
- Preserve exact matching for custom Bash allow rules
- Add coverage for the full-access Bash baseline
@wsp1911
wsp1911 merged commit 4f4d572 into GCWing:main Jul 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant