fix(permission): honor full access for Bash commands#1753
Merged
Conversation
- Recognize the full-access wildcard allow in Bash permission matching - Preserve exact matching for custom Bash allow rules - Add coverage for the full-access Bash baseline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Type and Areas
Type:
Regression fix
Areas:
Rust core
Motivation / Impact
Full access resolves to a
*/* -> Allowbaseline, but the Bash-specific matcher previously ignored that rule and fell back to Ask. Bash commands now honor Full access while custom wildcard Bash allow rules remain non-authorizing for compound commands.Verification
cargo check -p bitfun-core --features product-fullcargo test -p bitfun-core --features product-full --lib full_access_baseline_allows_bash_commandsReviewer Notes
*/* -> Allowbaseline; custom Bash Allow rules still require an exact command match.Checklist