Skip to content

ci: move SDK tests into CLI job #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limityan merged 1 commit into from
Jul 26, 2026
Merged

ci: move SDK tests into CLI job #1773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,17 @@ jobs:
cache-bin: false
save-if: ${{ github.event_name != 'pull_request' }}

- name: Run CLI, ACP, SDK Host, and agent runtime tests
run: cargo test --locked -p bitfun-cli -p bitfun-acp -p bitfun-sdk-host -p bitfun-sdk-host-app -p bitfun-agent-runtime
- name: Run CLI, ACP, and agent runtime tests
run: cargo test --locked -p bitfun-cli -p bitfun-acp -p bitfun-agent-runtime

- name: Run SDK Host tests
run: cargo test --locked -p bitfun-sdk-host -p bitfun-sdk-host-app

- name: Run SDK Host terminal cleanup regressions
run: |
cargo test --locked -p terminal-core shutdown_returns_only_after_process_exit_is_confirmed -- --test-threads=1
cargo test --locked -p terminal-core shutdown_evicts_a_process_whose_controller_already_confirmed_exit -- --test-threads=1
cargo test --locked -p terminal-core background_only_binding_is_owned_by_the_session -- --test-threads=1

# ── Rust: build check ─────────────────────────────────────────────
rust-build-check:
Expand Down Expand Up @@ -137,18 +146,6 @@ jobs:
- name: Check compilation
run: cargo check --locked --workspace

- name: Run SDK Host terminal cleanup regressions
# This PR changes only the PTY/session shutdown path required by
# connection-scoped Session cleanup. Keep the gate scoped to those
# regressions instead of adopting unrelated terminal command tests.
run: |
cargo test --locked -p terminal-core shutdown_returns_only_after_process_exit_is_confirmed -- --test-threads=1
cargo test --locked -p terminal-core shutdown_evicts_a_process_whose_controller_already_confirmed_exit -- --test-threads=1
cargo test --locked -p terminal-core background_only_binding_is_owned_by_the_session -- --test-threads=1

- name: Run standalone SDK Host process smokes
run: cargo test --locked -p bitfun-sdk-host-app --test process_initialization --test stdio_process

- name: Run Windows ConPTY CLI smoke test
if: runner.os == 'Windows'
run: cargo test --locked -p bitfun-cli --test terminal_process_contracts
Expand Down