Skip to content

ci: move Windows CLI terminal tests to nightly - #1774

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/ci-conpty-nightly
Jul 26, 2026
Merged

ci: move Windows CLI terminal tests to nightly#1774
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/ci-conpty-nightly

Conversation

@limityan

Copy link
Copy Markdown
Collaborator

Summary

  • remove the Windows CLI terminal process contracts from the daily CI Rust matrix
  • run the same contracts in the Windows nightly package path
  • disable incremental compilation and debug symbols for the nightly test profile to bound disk and link cost

Why

The Windows ConPTY step in run 30193605654 took 4 minutes 17 seconds, while its five tests completed in 2.83 seconds; almost all of the time was a separate Windows test-profile compile and link. Keeping that step serialized in daily CI materially extends the Windows critical path.

Nightly retains the native Windows terminal coverage for resize, cancellation, Ctrl+C, and cleanup without making every pull request pay that cost.

Impact

Workflow Before After
Daily CI Windows runs terminal_process_contracts on every PR and main push keeps cross-platform workspace compilation but omits the Windows process suite
Nightly Windows packages the Windows build without this process suite runs terminal_process_contracts before packaging
Linux and macOS unchanged unchanged

The observed daily Windows critical path should drop by roughly four minutes. The same cost moves to the weekday nightly Windows package job.

Validation

  • ConPTY workflow placement structural assertion
  • pnpm run check:github-config
  • git diff --check

@limityan
limityan marked this pull request as ready for review July 26, 2026 08:30
@limityan
limityan merged commit 3eb7090 into GCWing:main Jul 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant