ci: move Windows CLI terminal tests to nightly - #1774
Merged
Conversation
limityan
marked this pull request as ready for review
July 26, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Windows ConPTY step in run 30193605654 took 4 minutes 17 seconds, while its five tests completed in 2.83 seconds; almost all of the time was a separate Windows test-profile compile and link. Keeping that step serialized in daily CI materially extends the Windows critical path.
Nightly retains the native Windows terminal coverage for resize, cancellation, Ctrl+C, and cleanup without making every pull request pay that cost.
Impact
The observed daily Windows critical path should drop by roughly four minutes. The same cost moves to the weekday nightly Windows package job.
Validation