fix(flow-chat): reconcile pinned viewport reservations - #1878
Merged
Conversation
- settle collapse compensation according to semantic viewport ownership - hand off sticky pins once measured growth exhausts the remaining floor - add regression coverage for reservation settlement and tail handoff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type:
Areas:
Motivation / Impact
Pinned turns could remain outside tail-follow after output had reached the viewport bottom because provisional collapse space accumulated or sticky-pin growth repeatedly reset a 300 ms quiet timer.
This change assigns reservation settlement to the active viewport owner and treats complete pin-floor consumption as an immediate handoff boundary. Users should enter continuous tail-follow when output reaches the bottom without waiting for the stream to end or seeing a delayed catch-up jump.
Verification
pnpm run type-check:web- passedpnpm run lint:web- passedpnpm --dir src/web-ui run test:run src/flow_chat/components/modern/VirtualMessageList.session-boundary.test.tsx src/flow_chat/components/modern/FlowChatViewportCoordinator.test.ts- 58 tests passedgit diff --check- passedReviewer Notes
Checklist