perf(test): isolate runtime test support and consolidate CLI contracts - #2008
Merged
limityan merged 1 commit intoAug 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-runtime-services::test_supportout of ordinary library builds and enable it only for owner tests or explicit dev-dependency consumers.cargo test -p bitfun-runtime-servicesstill runs all 11 tests.cli_command_contractstarget while keeping ACP and terminal process contracts independent.test-supportfeature edges.No GitHub Actions workflow was added or changed.
Architecture
Build impact
Measurements used the same Windows worktree and dependency cache, warmed each feature fingerprint, cleaned only
bitfun-cli, and forced-j 1because other workspace builds were active on the host.test --no-runThe wall-time result is intentionally reported as near-neutral rather than a large speedup; the material win is reduced duplicate test artifacts without losing focused test filters.
Validation
pnpm run fmt:rspnpm run check:core-boundaries:test— 44/44pnpm run check:core-boundariescargo check --workspace --exclude bitfun-desktop --lockedcargo test -p bitfun-runtime-services --locked— 11/11cargo test -p bitfun-product-capabilities --locked— 30/30cargo test -p bitfun-cli --locked --test acp_stdio_cli --test cli_command_contracts --test terminal_process_contracts— 41/41cargo test -p bitfun-agent-runtime --tests --lockedcargo test -p bitfun-core --features product-full --lib --locked— 1814 passed, 1 ignoredA full
cargo check --workspace --lockedreached the desktop build script and stopped because this isolated worktree does not contain generatedsrc/mobile-web/dist. The same check excludingbitfun-desktoppassed; no generated frontend output was created or committed.Two independent adversarial reviewers examined the feature graph, layer direction, Cargo test discovery, path equivalence, focused-test behavior, and checker scope over multiple rounds. The final reduced design has no outstanding P1/P2 finding.