fix: make workspace icons consistent between active and inactive states - #2044
Open
xielixing wants to merge 1 commit into
Open
fix: make workspace icons consistent between active and inactive states#2044xielixing wants to merge 1 commit into
xielixing wants to merge 1 commit into
Conversation
…es (GCWing#1849) Active workspaces showed a DotMatrixArrowRightIcon (arrow) instead of the normal folder/letter icon, making active and inactive workspaces look like different entity types. Remove the isActive conditional from both the assistant workspace and normal workspace branches so all rows always use the same icon regardless of active state. Clean up now-dead SCSS rules for the removed active-icon classes. Add a layout test to prevent regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1849
When a workspace is active, it showed a \DotMatrixArrowRightIcon\ (arrow) instead of the normal folder/letter icon. This made active and inactive workspaces look like different entity types rather than siblings.
Root Cause
In \WorkspaceItem.tsx, both the assistant workspace branch and the normal workspace branch used \isActive ?\ to conditionally render different icons:
Fix
Remove the \isActive\ conditional from both branches so active and inactive workspaces always use the same icon:
The active state is still visually indicated by the existing \is-active\ CSS class, \�ria-current, and \data-workspace-active\ attributes — only the icon swap was removed.
Changes
Testing