Skip to content

fix(cli): harden mcp add configuration - #2099

Merged
wgqqqqq merged 1 commit into
GCWing:mainfrom
wgqqqqq:fix/cli-mcp-add-safety
Aug 6, 2026
Merged

fix(cli): harden mcp add configuration#2099
wgqqqqq merged 1 commit into
GCWing:mainfrom
wgqqqqq:fix/cli-mcp-add-safety

Conversation

@wgqqqqq

@wgqqqqq wgqqqqq commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reject duplicate MCP server IDs instead of overwriting existing configuration
  • parse local MCP commands with platform-aware quoting rules
  • require an explicit server type in non-interactive mode
  • add focused unit and CLI contract coverage for all three cases

Verification

  • pnpm run fmt:rs
  • cargo check -p bitfun-cli
  • cargo test -p bitfun-cli
  • git diff --cached --check

Fixes follow-up issues found while reviewing #2064.

@wgqqqqq
wgqqqqq merged commit 3d3f42c into GCWing:main Aug 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant