fix(desktop): support Petdex v2 sprites and directional pet actions - #2982
Merged
Conversation
Preserve sprite versions through package import and saved selections, render v1 and v2 atlases with their frame counts, and bound v2 pointer look playback. Use directional running during dragging, jump on new requests, and wave on completion or release. Keep Windows drag state active until pointer release and cover legacy metadata, rendering, and interaction transitions with tests.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Petdex v2 companions being rendered as nine-row sheets and directional run animations being mapped to hover and undirected dragging.
Type and Areas
Type: Bug fix / UI interaction fix
Areas: Desktop/Tauri, shared configuration contracts, Web UI
Motivation / Impact
Existing v1 pets continue to work, while v2 sheets use all eleven rows without incorrect cropping. Pointer look no longer indefinitely masks idle animation. Directional running follows movement, and request-start and completion reactions have distinct triggers.
Verification
pnpm --dir src/web-ui exec vitest run src/flow_chat/components/AgentCompanionPet.test.tsx src/app/components/AgentCompanionDesktopPet/AgentCompanionDesktopPet.test.tsx src/infrastructure/config/services/AgentCompanionDragService.test.ts src/infrastructure/config/services/agentCompanionPetSprite.test.ts src/infrastructure/config/services/AgentCompanionPetCompatibility.test.ts— 32 tests passed.pnpm run check:web— passed.pnpm run motion:audit— completed; reviewed the motion inventory.pnpm run i18n:audit— passed.pnpm run fmt:rsandgit diff --check— passed.Reviewer Notes
AI-assisted; lightly tested overall. Automated coverage includes legacy metadata round trips, v1/v2 rendering, reduced-motion handling, idle restoration, directional dragging, release/cancellation, and duplicate activity notifications.
The focused desktop Rust package tests were added but have not been executed separately. Final interaction behavior has not been visually verified across platforms. Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised; no new remote protocol or commands are introduced. No before/after recording is attached.
No pet artwork, imported packages, or temporary artifacts are included.
Checklist