refactor(examples): share pad logic via TPadController and IPadShell - #1
Merged
Conversation
Extract the application logic duplicated between the VCL and FMX MarkdownPad demos into a framework-agnostic TPadController, driven through IPadEditorView and a new IPadShell seam. Document lifecycle, command palette, the editing loop (change/tick/status/title/find/TOC-sync/reload/close-query) and HTML export/copy now live once in Examples/Shared; the forms keep only control construction, rendering and the two interface implementations. Split the per-app constants into MarkdownPadVCL.Defines / MarkdownPadFMX.Defines and move the shared RecentShortcut into MarkdownPad.Defines. View-mode and zen stay in the forms as framework view logic.
cmgeuze
force-pushed
the
refactor/shared-pad-controller
branch
from
July 24, 2026 07:32
ee98dd8 to
c4374c0
Compare
cmgeuze
added a commit
that referenced
this pull request
Jul 30, 2026
refactor(examples): share pad logic via TPadController and IPadShell
cmgeuze
added a commit
that referenced
this pull request
Aug 31, 2026
refactor(examples): share pad logic via TPadController and IPadShell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the application logic duplicated between the VCL and FMX MarkdownPad demos into a framework-agnostic
TPadController, driven throughIPadEditorViewand a newIPadShellseam.Moved to Examples/Shared (once, framework-agnostic):
The forms keep only control construction, rendering and the two interface implementations. View-mode and zen stay in the forms as framework view logic; the
FTocFollowingreentrancy guard stays FMX-only (VCL's list fires no change on a programmatic ItemIndex).Also splits the per-app constants into
MarkdownPadVCL.Defines/MarkdownPadFMX.Definesand moves the sharedRecentShortcutintoMarkdownPad.Defines.Both VCL and FMX build clean with zero hints/warnings.