Build the alternate content sample instead of shipping a user's document - #36
Merged
Merged
Conversation
The reproduction attached to issue #34 was a real document from a third party, carrying its author name in docProps and content that is not ours to redistribute. The fixture now assembles a document stating the same construct: runs wrapping mc:AlternateContent whose branches each nest a w:p in a text box, followed by a plain run. Verified against the pre-fix reader, where it fails on the same four counts the attached document did. The zip scaffolding the docx and pptx fixtures each carried moves to TTestPackage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35.
The reproduction attached to issue #34 was a real document from a third party. It carried its author's name in
docProps/core.xml, four pages of a Spanish car manual's table of contents, and an embedded icon. None of that is ours to redistribute, and none of it is needed to state the construct the reader has to get right.The fixture now assembles the document itself: runs wrapping
mc:AlternateContentwhosemc:Choiceandmc:Fallbackeach nest aw:pin a text box, followed by a plain sibling run. One test uses thirteen such runs in a single paragraph, matching the shape of the reported document.Verified against the reader as it was before #35: the built document fails on the same four counts the attached one did, including the sibling run going missing and the shape text arriving twice.
The zip scaffolding that the docx and pptx fixtures each carried moves to
TTestPackageinOffice4D.Tests.PackageBuilder, so a fixture states only the body or slide XML it is about.Note that removing the file here does not remove it from history; it stays reachable in the commits merged by #35. Say the word if it should be purged properly, that needs a history rewrite and a force push.
Debug and Release builds: 0 warnings, 0 errors. Suite: 330 tests, all green, no memory leaks.