chore: fix wdc time assertion#80
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WDC Dst time-range handling to normalize start_time/end_time to UTC before validating the requested interval, aiming to prevent timezone-related comparison issues.
Changes:
- Normalize
start_timeandend_timeviaenforce_utc_timezone()before validation indownload_and_process(). - Replace the previous invalid-range
ValueErrorhandling inread()with an assertion after timezone normalization.
Comments suppressed due to low confidence (1)
swvo/io/dst/wdc.py:235
read()previously raisedValueError("start_time must be before end_time")when the time range was invalid (and the tests assert this). This change replaces it with anassert start_time < end_time, which (1) changes the exception type toAssertionError, (2) changes the allowed boundary condition (start==end used to be allowed), and (3) can be skipped entirely when Python is run with optimizations (-O). Keep the timezone normalization (to avoid naive/aware comparison errors), but restore the explicitValueErrorcheck/message.
start_time = enforce_utc_timezone(start_time)
end_time = enforce_utc_timezone(end_time)
assert start_time < end_time, "Start time must be before end time!"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.