Skip to content

[oshdb-filter] handle "other" geometry type occuring as side effect of clipping #338

@tyrasd

Description

@tyrasd

Bug Description

A geometry:other filter should also select features which became a GeometryCollection as the result of clipping to the area of interest. Currently, it doesn't because the filter pre-selects only relations (e.g. here).

This will also resolve make sure that filtering for (geometry:point or geometry:line or geometry:polygon or geometry:other) will actually select all features.

How to Reproduce

Steps to reproduce the behaviour:

  1. Execute the following ohsome API query: https://api.ohsome.org/v1/elements/geometry?bboxes=8.700582,49.4143039,8.701247,49.414994&showMetadata=true&time=2018-01-02&filter=building=*%20and%20geometry:other
  2. the result is empty

Expected behaviour

There should be exactly one feature in the result (way/181679235). As produced by https://api.ohsome.org/v1/elements/geometry?keys=building&bboxes=8.700582,49.4143039,8.701247,49.414994&showMetadata=true&types=other&time=2018-01-02

Further Information

Error messages, logs, screenshots

This is the GeometryCollection in question: https://gist.github.com/tyrasd/6ea689b9e0b80fcd43570d12b72263bf

System information

Please complete the following information:

  • OSHDB Version: e.g. 0.6.*

Metadata

Metadata

Assignees

No one assigned

    Labels

    addressingSomeone is addressing this issue. You should contact them, before making any contributions.bugSomething isn't working as expected

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions