Skip to content

[oshdb-filter] also non-relations should match geometry:other#341

Merged
tyrasd merged 4 commits into
masterfrom
fix-issue-338
Feb 2, 2021
Merged

[oshdb-filter] also non-relations should match geometry:other#341
tyrasd merged 4 commits into
masterfrom
fix-issue-338

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Jan 22, 2021

Description

When done, this will make sure that filtering for (geometry:point or geometry:line or geometry:polygon or geometry:other) will actually select all features.

Corresponding issue

Fixes #338

Checklist

@tyrasd tyrasd added the bug Something isn't working as expected label Jan 22, 2021
@tyrasd tyrasd added this to the release 0.7.0 milestone Jan 22, 2021
@tyrasd tyrasd self-assigned this Jan 22, 2021
@tyrasd tyrasd force-pushed the fix-issue-338 branch 2 times, most recently from f538544 to c716749 Compare January 25, 2021 13:40
@tyrasd tyrasd changed the title 🚧 [oshdb-filter] also non-relations should match geometry:other [oshdb-filter] also non-relations should match geometry:other Jan 25, 2021
@tyrasd tyrasd added comments welcome Indicates that the creator of this issue/PR is open for early review comments help wanted Extra attention is needed and removed comments welcome Indicates that the creator of this issue/PR is open for early review comments help wanted Extra attention is needed labels Jan 26, 2021
@tyrasd tyrasd added waiting for review This pull request needs a code review and removed comments welcome Indicates that the creator of this issue/PR is open for early review comments labels Feb 1, 2021
Comment thread CHANGELOG.md Outdated
@tyrasd tyrasd merged commit 888ef98 into master Feb 2, 2021
@tyrasd tyrasd deleted the fix-issue-338 branch February 2, 2021 12:08
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[oshdb-filter] handle "other" geometry type occuring as side effect of clipping

2 participants