Skip to content

specify port range for the testing ignite instance#263

Merged
tyrasd merged 3 commits into
masterfrom
fix-parallel-testing
Oct 27, 2020
Merged

specify port range for the testing ignite instance#263
tyrasd merged 3 commits into
masterfrom
fix-parallel-testing

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Aug 28, 2020

This should allow unit tests to be run in parallel without interfering with each other. (hopefully 🤞 )

@tyrasd tyrasd added the waiting for review This pull request needs a code review label Sep 1, 2020
so that unit tests can be run in parallel without interfering with each other
@tyrasd tyrasd force-pushed the fix-parallel-testing branch from 3ec028c to d2e7f31 Compare October 26, 2020 17:48
@tyrasd tyrasd requested a review from joker234 October 26, 2020 17:48
@joker234 joker234 self-assigned this Oct 26, 2020
@joker234
Copy link
Copy Markdown
Member

Is there a issue related to this PR? What does this PR try to solve? Parallel executions of mvn test? If yes, the solution wasn't sufficient, I still get Exceptions from the ignite test instance.

This are example errors I get when running in parallel in at least two shells in separate working directories:

% mvn test
…
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   TestMapReduceOSHDB_Ignite_ScanQuery.testOSMContributionView:6->TestMapReduce.testOSMContributionView:58 » ComputeUserUndeclared
[ERROR]   TestMapReduceOSHDB_Ignite_ScanQuery.testOSMContributionViewStream:6->TestMapReduce.testOSMContributionViewStream:123 » Cache
[ERROR]   TestMapReduceOSHDB_Ignite_ScanQuery.testOSMEntitySnapshotView:6->TestMapReduce.testOSMEntitySnapshotView:91 » ComputeUserUndeclared
[ERROR]   TestMapReduceOSHDB_Ignite_ScanQuery.testOSMEntitySnapshotViewStream:6->TestMapReduce.testOSMEntitySnapshotViewStream:160 » Cache
[ERROR]   TestMapReduceOSHDB_Ignite_ScanQuery.testTimeoutMapReduce »  Unexpected excepti...
[INFO] 
[ERROR] Tests run: 125, Failures: 0, Errors: 5, Skipped: 0
…

@tyrasd
Copy link
Copy Markdown
Member Author

tyrasd commented Oct 27, 2020

Parallel executions of mvn test?

yes, that was the rationale behind it.

@tyrasd tyrasd changed the title specify port range for the testing ignite instance 🚧 specify port range for the testing ignite instance Oct 27, 2020
@tyrasd
Copy link
Copy Markdown
Member Author

tyrasd commented Oct 27, 2020

errors I get when running in parallel in at least two shells in separate working directories

confirming. I thought these were gone in my testing, but maybe I didn't test it properly.

The first actual exception I get is:

class org.apache.ignite.IgniteCheckedException: Failed to serialize object: org.heigit.bigspatialdata.oshdb.api.mapreducer.backend.OSHDBIgniteMapReduceComputeTask$1@[…]
[…]
Caused by: java.io.NotSerializableException: org.heigit.bigspatialdata.oshdb.index.XYGridTree$3

🤔

@tyrasd
Copy link
Copy Markdown
Member Author

tyrasd commented Oct 27, 2020

ok, I guess the problem was that the ipFinder property still had all possible ports listed (<value>127.0.0.1:47577..47599</value>), so the test client would always connect to the first test-server even when there were multiple ones running.

This should be addressed "properly" now (choosing a 1 in 1000 random port for each test run).

@tyrasd tyrasd changed the title 🚧 specify port range for the testing ignite instance specify port range for the testing ignite instance Oct 27, 2020
@joker234 joker234 removed the waiting for review This pull request needs a code review label Oct 27, 2020
@tyrasd tyrasd merged commit 198a921 into master Oct 27, 2020
@tyrasd tyrasd deleted the fix-parallel-testing branch October 27, 2020 13:39
@tyrasd tyrasd mentioned this pull request Jan 20, 2021
2 tasks
@tyrasd tyrasd added the CI Related to continuous integration (unit tests, build settings, etc.) label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Related to continuous integration (unit tests, build settings, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants