don't manipulate cluster state#335
Merged
Merged
Conversation
rtroilo
reviewed
Jan 20, 2021
rtroilo
approved these changes
Jan 21, 2021
tyrasd
force-pushed
the
fix-oshdb-clusterstate
branch
from
9f20409 to
bf4309c
Compare
tyrasd
force-pushed
the
fix-oshdb-clusterstate
branch
from
bf4309c to
cc29b66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSHDB-API should not change the state of an already running ignite cluster. If it is inactive, it might be for a reason, if it is in read-write mode, it might also be in that state for a reason, etc.
This is a regression in OSHDB version 0.6.0 introduced with #263.
Checklist
I have commented my codeI have written javadoc (required for public methods)I have added sufficient unit testsI have made corresponding changes to the documentationI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repositoryPlease check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~) and remove their checkboxes.