make isArea check more robust#31
Merged
Merged
Conversation
Very rarely osm data is not consistent (e.g. after partial data redactions), which can cause some of the affected osm data to produce invalid geometries (e.g. polygons that don't form closed rings) – one example for this is https://www.openstreetmap.org/way/265512886/ during the years 2015 and 2016. This makes the GeometryBuilder robust enough to detect these cases and fall back to the next steps of the geometry building pipeline. (also removes one accidentally committed debug sysout)
rtroilo
approved these changes
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very rarely osm data is not consistent (e.g. after partial data redactions), which can cause some of the affected osm data to produce invalid geometries (e.g. polygons that don't form closed rings) – one example for this is https://www.openstreetmap.org/way/265512886/ during the years 2015 and 2016.
This makes the GeometryBuilder robust enough to detect these cases and fall back to the next steps of the geometry building pipeline.
(also removes one accidentally committed debug sysout)