Skip to content

make isArea check more robust #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 1 commit into from
Oct 4, 2018
Merged

make isArea check more robust #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...til/src/main/java/org/heigit/bigspatialdata/oshdb/util/geometry/OSHDBGeometryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,16 @@ public static Geometry getGeometry(
.map(nd -> new Coordinate(nd.getLongitude(), nd.getLatitude()))
.toArray(Coordinate[]::new);
if (areaDecider.isArea(entity)) {
try {
if (coords.length >= 4 && coords[0].equals2D(coords[coords.length - 1])) {
return geometryFactory.createPolygon(coords);
} catch (IllegalArgumentException e) {
LOG.warn("way/{} should be closed - falling back to linestring geometry", way.getId());
System.out.println("way/"+way.getId()+" should be closed - falling back to linestring geometry");
return geometryFactory.createLineString(coords);
} else {
LOG.warn("way/{} doesn't form a linear ring - falling back to linestring", way.getId());
}
} else if (coords.length >= 2) {
}
if (coords.length >= 2) {
return geometryFactory.createLineString(coords);
} else if (coords.length == 1) {
}
if (coords.length == 1) {
LOG.info("way/{} is single-noded - falling back to point geometry", way.getId());
return geometryFactory.createPoint(coords[0]);
} else {
Expand Down