Skip to content

jts(1.18.2) and other dependencies plus reorganize version properties#432

Merged
rtroilo merged 2 commits into
masterfrom
update_jts_reorganize_version-properties
Sep 27, 2021
Merged

jts(1.18.2) and other dependencies plus reorganize version properties#432
rtroilo merged 2 commits into
masterfrom
update_jts_reorganize_version-properties

Conversation

@rtroilo
Copy link
Copy Markdown
Member

@rtroilo rtroilo commented Sep 21, 2021

This PR updates dependency versions

  • jts 1.16.1 > 1.18.2
  • wololo 0.13.0 > 0.16.1
  • guava 29.0-jre > 30.1.1-jre
  • slf4f 1.7.25 > 1.7.32

removes dependency versions/properties

  • apachecommons.version 3.1
  • commonsio.version 2.5
  • orgjson.version 20160810
  • osmosis.version 0.45

and reorganize properties, so that properties only used in a specific module is defined in this module instead.

Checklist

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@rtroilo rtroilo requested a review from tyrasd September 21, 2021 15:25
@rtroilo rtroilo added breaking This will introduce an incombability to previous versions. Documentation update compulsory and removed breaking This will introduce an incombability to previous versions. Documentation update compulsory labels Sep 21, 2021
@tyrasd tyrasd added the dependencies referes to one of our dependencies label Sep 22, 2021
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a changelog entry would be needed for this one

also we should check if this has an impact on issue #351 and/or performance.

@rtroilo
Copy link
Copy Markdown
Member Author

rtroilo commented Sep 23, 2021

a changelog entry would be needed for this one

added.

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Sep 24, 2021

also we should check […] performance.

I did some checks, and at least in our benchmarks I didn't see any big difference in performance with this PR.

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Sep 24, 2021

also we should check if this has an impact on issue #351

I tried the example test case from GIScience/ohsome-api#122 (comment), and didn't see an improvement, unfortunately.

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Sep 24, 2021

for needed follow-up changes in the ohsome api project see GIScience/ohsome-api#241

@rtroilo rtroilo merged commit bd3dab9 into master Sep 27, 2021
@rtroilo rtroilo deleted the update_jts_reorganize_version-properties branch September 27, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies referes to one of our dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants