Adding recipes and logger module#105
Merged
Merged
Conversation
Collaborator
Author
|
Added deeptime dependency, it's necessary for TICA, it was not tested before but now it's in the docs and thus necessary. |
andrewtarzia
requested changes
Jul 4, 2025
andrewtarzia
left a comment
Collaborator
There was a problem hiding this comment.
This is great. Focussing on the logger in this review. Love it though
andrewtarzia
requested changes
Jul 17, 2025
andrewtarzia
left a comment
Collaborator
There was a problem hiding this comment.
Some minor things, @matteobecchi, otherwise great work!
Collaborator
Author
|
@andrewtarzia installation is failing on remote with python 3.13 and I can't understand why. Everything works on my local machine, and I only made "esthetic" changes in the docs. It says "Failed to build dscribe" |
andrewtarzia
approved these changes
Jul 17, 2025
andrewtarzia
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested Reviewers: @andrewtarzia
Recipes:
dynsight.logs: it creates an instance of the Logger class, that is then used throughout the user's script allowing at the end to save a log.txt file.