chore: loosen stomp-py constraint to >=6.0.0#212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loosens the stomp-py dependency from ==6.0.0 to >=6.0.0 in gridappsd-python-lib/pyproject.toml, making it consistent with pixi.toml (already >=6.0.0).
Justified by the GADP-044 fix (PR #210): _unpack_stomp_args now handles both the stomp-py 6.x two-arg callback shape and the 8.x/9.x Frame shape, so pinning to exactly 6.0.0 is artificially strict and produced a dependency-conflict warning in the platform build (gridappsd-python requires stomp-py==6.0.0 but the platform force-upgrades to 9.0.0 via test-stomp-topics).
Verified under BOTH stomp-py 6.0.0 (floor) and 9.0.0 (latest): callback extracts (header, message) correctly using the real stomp.utils.Frame, full suite green, ruff/format/mypy clean.
Note: gridappsd-field-bus-lib/info/requirements.txt still hard-pins stomp-py==6.0.0 but is a stale pip-freeze export not referenced by any build; left untouched, flagged separately.