security: remove dead pip-freeze snapshot carrying 11 Dependabot CVE alerts#218
Merged
Merged
Conversation
…alerts Removes gridappsd-field-bus-lib/info/requirements.txt, a stale pip-freeze export that no CI workflow, Dockerfile, pixi config, or source file references (confirmed via full-repo grep). The file pinned vulnerable versions that generated 11 open Dependabot alerts: - urllib3==1.26.20: 5 alerts (4 HIGH, 1 MEDIUM) GHSA-qccp-gfcp-xxvc, GHSA-38jv-5279-wg99, GHSA-2xpw-w6gg-jr37, GHSA-gm62-xv2j-4w53, GHSA-pq67-6m6q-mj2v - requests==2.28.2: 4 MEDIUM alerts GHSA-gc5v-m9x4-r6x2, GHSA-9hjg-9r4m-mvj7, GHSA-9wx4-h78v-vm56, GHSA-j8r2-6x86-q33q - idna==3.10: 1 MEDIUM alert (GHSA-65pc-fj4g-8rjx) - pygments==2.19.2: 1 LOW alert (GHSA-5239-wwwm-4pmq) The file was never installed by any build, test, or deploy step; it was only ever touched by automated version-bump commits. The real dependency declaration for gridappsd-field-bus-lib lives in gridappsd-field-bus-lib/pyproject.toml. This mirrors PR #214 which already removed the same file from the develop branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
gridappsd-field-bus-lib/info/requirements.txt, a stale pip-freeze export that no CI workflow, Dockerfile, pixi config, or source file references (confirmed via full-repo grep). The file is never installed by any build, test, or deploy step; it was only ever touched by automated version-bump commits. Deleting it closes all 11 open Dependabot alerts.This mirrors PR #214, which already removed this same file from the
developbranch with the same rationale and confirmed tests still pass (pixi run test: 51 passed, test-field-bus: 10 passed).Alerts resolved
urllib3==1.26.20 (was 5 alerts, 4 HIGH + 1 MEDIUM):
requests==2.28.2 (was 4 MEDIUM alerts):
idna==3.10 (was 1 MEDIUM alert):
Pygments==2.19.2 (was 1 LOW alert):
Total: 11 alerts resolved (4 HIGH, 6 MEDIUM, 1 LOW).
Why delete rather than bump
The file is a dead pip-freeze export with no consumer. The real field-bus dependency declaration is in
gridappsd-field-bus-lib/pyproject.toml. A clean venv install frompyproject.tomlalready resolves urllib3 2.7.0, requests 2.34.2, idna 3.18, and Pygments 2.20.0: all safe versions. Bumping pins in a file that is never installed would leave the file in place as a future alert source.Verification
gridappsd-field-bus-lib/pyproject.tomlsucceeded;import gridappsd_field_buspasses.pyproject.toml: urllib3 2.7.0, requests 2.34.2, idna 3.18, Pygments 2.20.0 (all at or above safe floors).git diff --name-only origin/main...HEADshows exactly one file changed.