-
Notifications
You must be signed in to change notification settings - Fork 33
Staging release: Rust widget renderer #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rileyseaburg
wants to merge
60
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,028
−206
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
b70a34b
Merge pull request #1898 from GSA/feature/rust-widget-renderer
rileyseaburg 539f661
Tighten ignore for env/vars files
rileyseaburg bb3cd67
Look for widget artifact in workspace target dir
rileyseaburg 8af0c02
Fix widget build script app root detection
rileyseaburg 2db8e84
Make widget build script locate ext directory flexibly
rileyseaburg 51bbc6a
Link rutie against shared ruby in runtime build
rileyseaburg 36b2721
Avoid rutie static link; skip linking when building at runtime
rileyseaburg a80e494
Prefer cached Rust toolchain in runtime build
rileyseaburg 2eaaf05
Ensure widget .so is included in CF bits
rileyseaburg 6143f92
Copy shipped widget .so into target/release at runtime
rileyseaburg fa7dbbe
Let Rutie define WidgetRenderer (drop Ruby module wrapper)
rileyseaburg d598548
Load widget renderer from lib/widget_renderer
rileyseaburg 8d0bbd1
Remove stale WidgetRenderer module before Rutie init
rileyseaburg 936da01
Guard WidgetRenderer constant as class before Rutie init
rileyseaburg a23cc09
Allow app-staging host in staging manifest
rileyseaburg 1fa69f2
Use app-staging as asset host to satisfy SRI
rileyseaburg c1ecb52
Scope session cookie domain via optional env
rileyseaburg d98161b
Point LOGIN_GOV_REDIRECT_URI to app-staging host
rileyseaburg 9c96767
Pass question text field to Rust renderer
rileyseaburg faf7e69
Clean up cx collections export tests and fix service csv list
rileyseaburg b420feb
Merge branch 'feature/rust-widget-renderer' into develop
rileyseaburg 4580b73
Bump Ruby to 3.4.7
rileyseaburg 6cc6804
Build Rust widget renderer in CircleCI
rileyseaburg 4b566d9
Use cargo build for widget renderer in CI
rileyseaburg 8ff23e8
Coerce nil booleans before calling Rust renderer
rileyseaburg 2dfa28e
Skip Rust widget renderer in test env to stabilize specs
rileyseaburg 0c32cce
Default element_selector for widget renderer
rileyseaburg 609891d
Stabilize form permissions spec expectations
rileyseaburg c6fe6d2
Revert Ruby target to 3.2.8 for CF buildpack
rileyseaburg 1b0c575
Use prebuilt widget renderer .so before compiling at runtime
rileyseaburg b92b49b
Fix widget renderer build artifact detection
rileyseaburg 0081849
Make widget renderer tolerate null booleans
rileyseaburg d48eeb4
Add logging and extra fallback for widget renderer .so in pre-start
rileyseaburg cf2a312
Allow widget renderer pre-start to build if no prebuilt lib
rileyseaburg 0395cf6
Set HOME to /home/vcap before building widget renderer
rileyseaburg fc0ebbe
Harden widget renderer runtime build paths
rileyseaburg 42d9cc4
Trigger CircleCI deploy
rileyseaburg 21c7ccf
Guard CF deploy steps to a single parallel node
rileyseaburg 16004a5
Precompile done.svg so the landing page renders
rileyseaburg 1bea5e4
Link done.svg in manifest and clean precompile entry
rileyseaburg ee4a044
Allow asset fallback in staging
rileyseaburg 4203ce3
Enable Rack::Attack middleware
rileyseaburg 12b0b2f
Stabilize digital product create feature spec
rileyseaburg 2e448c4
Loosen digital product path assertion
rileyseaburg 82b503d
Avoid runtime Rust build in widget renderer
rileyseaburg 2c78f55
Increase memory allocation to 2G for Rust widget renderer
rileyseaburg 273f1d0
Fix SRI CORS issue by adding crossorigin attribute to asset tags
rileyseaburg 54b8531
Add CORS headers for static assets to support SRI cross-origin requests
rileyseaburg 2af401e
Add prebuilt Linux libwidget_renderer.so for Cloud Foundry deployment
rileyseaburg 051deb6
Add debug logging for WidgetRenderer initialization
rileyseaburg 73380ed
Add debugging output to widget_renderer.rb
rileyseaburg 0480a2b
Fix: Copy library to expected location when found in workspace target…
rileyseaburg d3e0271
Fix: Set LD_LIBRARY_PATH for libruby.so at runtime on Cloud Foundry
rileyseaburg 6a9cac1
Fix flaky test: explicitly set service to twitter for digital_service…
rileyseaburg 3596c94
Add retry logic to CF deploy scripts to handle staging race conditions
rileyseaburg e7b114a
Add deployment wait logic to prevent CF supersession errors
rileyseaburg 3475fe0
Add CF env-based deploy lock to serialize concurrent pipelines
rileyseaburg 14288a9
Build Rust extension at runtime on CF to fix libruby.so linking
rileyseaburg e304dff
Check library linkage before using - rebuild if libruby not found
rileyseaburg 2f0c4ae
Add Cargo caching and library linkage verification to CircleCI
rileyseaburg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The negation pattern on line 44 won't work as intended because line 43 already ignores the parent directory
ext/widget_renderer/target/. In gitignore-style patterns, once a parent directory is ignored, you cannot un-ignore it with a negation pattern before un-ignoring its contents.Consider removing line 43 (
ext/widget_renderer/target/) and keeping only line 42 (target/) which already covers this path. The specific negations on lines 45-46 should then work correctly.