feat(registry): add a reusable docs landing block - #8
Merged
Conversation
Owner
Author
|
The pushed branch resolves as a real GitHub registry now. Review it with: pnpm dlx shadcn@latest view GSTJ/magic/docs-landing#agent/docs-landing-registry. Remote registry validation passes for GSTJ/magic#agent/docs-landing-registry. The unpinned install command in the README becomes active after this PR lands on main. |
Owner
Author
|
Follow-up Review without writing files: pnpm dlx shadcn@latest add GSTJ/magic/docs-landing#agent/docs-landing-registry --dry-runFresh integration verification: full |
GSTJ
force-pushed
the
agent/docs-landing-registry
branch
from
July 28, 2026 23:25
a722f7e to
f275b89
Compare
…th CI jobs Nothing under registry/ is a package, so `turbo run typecheck` never compiled it and a TypeScript or React bump could break the four files a consumer installs while this repo stayed green. registry/tsconfig.json extends magic-tsconfig/nextjs and `pnpm run typecheck` runs it. `validate-registry` was in the root check script but not in self-ci.yml's extra-command, so the reusable-workflow job skipped it. Both lists now match. README drops the PR-branch install command and records the CHANGELOG round. Claude-Session: https://claude.ai/code/session_01Xw8Aynvwi5a3xzD79he3z1
GSTJ
force-pushed
the
agent/docs-landing-registry
branch
from
July 28, 2026 23:31
f275b89 to
b308786
Compare
GSTJ
marked this pull request as ready for review
July 28, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pnpm dlx shadcn@latest add GSTJ/magic/docs-landingwrites four editable filesinto a consumer repo. They cover a dark landing shell, hero, stat strip,
sections with three layouts and five tones, a demo frame, a release timeline, a
final CTA, a footer, and an accessible clipboard button for the install command.
It installs
gsap@3.15.0and nothing else. Demos, examples, palette overridesand copy stay in the repo that installs it.
Also here:
registry.jsonat the repo root, plus the flatpublic/rpayloads for theHTTPS address the shadcn Registry Directory will want later
scripts/validate-registry.mjs, which checks catalog metadata, item names andtypes, the file list, embedded source, missing and extra output, and stale
generated payloads, with 185 lines of tests behind it
registry/tsconfig.json, because nothing underregistry/is a package andturbo run typecheckwas never compiling these filesScreenshots
Installed from this branch into a clean Next 16.2.12 app with strict TypeScript
and
noUncheckedIndexedAccess, then composed into a page that exercises everyexport.
Same page under
prefers-reduced-motion: reduce, captured without scrolling.All 19 reveal targets are at full opacity because the reveal timelines never
register under that media query:
Review notes
All fixed in
b308786.The branch was three commits behind main, including the
magic-oxlint-config@2.0.0breaking release, so the green CI on the old headwas green against the wrong base. Rebased;
pnpm run checkis 95/95 on the newone.
Nothing typechecked the block.
registry/is not a package, so no buildcompiles it and
turbo run typecheckskipped it: four files, ~1700 lines, thata consumer compiles and this repo did not.
registry/tsconfig.jsonextendsmagic-tsconfig/nextjsandpnpm run typecheckruns it. Broke a type onpurpose to confirm it fails on one.
validate-registryonly ran in one of the two CI jobs. It was in the rootcheckscript but not inself-ci.yml'sextra-command, so thereusable-workflow job skipped it. Both lists match now.
The CLI resolves
GSTJ/magic/docs-landingby readingregistry.jsonand thesource files from raw.githubusercontent, so the install works with nothing
hosting the repo.
public/ris not on that path. It is there for the RegistryDirectory entry, which needs a stable HTTPS URL this repo does not have yet. The
README says so.
The presets are untouched, so the
extendConfigrule is unaffected.gsap,react,react-domand@types/reactare new root devDependencies, only sothe typecheck can resolve what the block imports.
Validation
pnpm run checkon the rebased branch: pass, 95/95 adversarial expectationspnpm run typecheck:registry: pass, and fails on a deliberately broken typepnpm run validate-registry: passto
@/components/docs-landing/*,gsap@3.15.0addedtsc --noEmitandnext buildin the installed fixture: passand zero elements left hidden