ci: call the shared workflow by tag instead of @main - #29
Merged
Conversation
The workflow was pointing at GSTJ/magic@main, so any merge over there reran this repo's CI with whatever had just landed. `@v1` is the moving major tag: fixes still arrive on the next run, but only after a release. ci.yml and the setup composite are identical at v1 and main right now, so this is a no-op for the current run. The four inputs passed here (build-command, test-command, extra-command, turbo-cache) all exist in v1's workflow_call signature with the same types. The magic-* devDependencies are already on the current latest (1.2.0, magic-codemods 1.1.0), so nothing to bump. magic-oxlint-plugin stays out — this repo enables none of its rules. Claude-Session: https://claude.ai/code/session_01Fe92vvdc4R3F4BDBFoLcw1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/ci.ymlcalledGSTJ/magic/.github/workflows/ci.yml@main, so an unreviewed merge in the tooling repo reran this repo's CI. Switched to@v1, the moving major tag — fixes still arrive on the next run, just after a release rather than after a merge.ci.ymland thesetupcomposite are byte-identical betweenv1(v1.4.0) andmaintoday, so this changes nothing about what runs. The four inputs this repo passes —build-command,test-command,extra-command,turbo-cache— all exist in v1'sworkflow_callsignature with matching types (turbo-cacheis a boolean there, which is what's passed).Nothing else to do here:
magic-*devDependencies are already on the current latest (magic-oxlint-config/magic-oxfmt-config/magic-tsconfig1.2.0,magic-codemods1.1.0);magic-oxlint-pluginstays out — this repo enables none of its rules;pnpm install --frozen-lockfilepasses against the committedminimumReleaseAgeExcludelist, so no new quarantine entries were needed.Verified locally: install (frozen),
lint0 diagnostics,format --checkclean,typecheck, 5 jest tests,build,npm pack --dry-run.Claude-Session: https://claude.ai/code/session_01Fe92vvdc4R3F4BDBFoLcw1