Update dirty repo check to not include config files#175
Merged
mikewoodward94 merged 3 commits intoOct 31, 2024
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
AgatheZ
reviewed
Oct 31, 2024
AgatheZ
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me @mikewoodward94
Just one suggestion: can we ignore the entire config/ folder instead of individual files?
I personally have more than 2 config files in my config folders for most of my projects, and that would allow us to be more flexible
AgatheZ
approved these changes
Oct 31, 2024
mikewoodward94
deleted the
93-git-check-will-always-return-dirty-repository
branch
October 31, 2024 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently always need to use --ignore_git_check as config files are always different to those on repo (due to passwords).
Now config files are ignored and this flag shouldn't be necessary.