Skip to content

Update dirty repo check to not include config files#175

Merged
mikewoodward94 merged 3 commits into
mainfrom
93-git-check-will-always-return-dirty-repository
Oct 31, 2024
Merged

Update dirty repo check to not include config files#175
mikewoodward94 merged 3 commits into
mainfrom
93-git-check-will-always-return-dirty-repository

Conversation

@mikewoodward94

Copy link
Copy Markdown
Collaborator

Currently always need to use --ignore_git_check as config files are always different to those on repo (due to passwords).

Now config files are ignored and this flag shouldn't be necessary.

@mikewoodward94 mikewoodward94 self-assigned this Oct 30, 2024
@mikewoodward94 mikewoodward94 linked an issue Oct 30, 2024 that may be closed by this pull request
@github-actions

github-actions Bot commented Oct 30, 2024

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
mlops
   Experiment.py1563180%44–49, 72, 77–78, 99, 101, 106, 176–190, 209, 211–212, 260–261, 265–269, 273–274, 281–282
   ProjectFile.py23196%41
   cli.py541769%19–22, 36, 58–64, 84–86, 94–97, 105–106, 111
mlops/release
   Release.py33779%24, 28, 33–38
mlops/release/destinations
   ReleaseDestination.py9189%18
   SharepointDestination.py6267%12–13
   ZenodoDestination.py331942%21–25, 29–35, 43–60
mlops/release/sources
   MLFlowSource.py13654%13–14, 21–27
   ReleaseSource.py14286%14, 23
mlops/utils
   Config.py17170%1–24
TOTAL39510374% 

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 3m 21s ⏱️

@AgatheZ AgatheZ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @mikewoodward94
Just one suggestion: can we ignore the entire config/ folder instead of individual files?

I personally have more than 2 config files in my config folders for most of my projects, and that would allow us to be more flexible

@mikewoodward94
mikewoodward94 merged commit 34fb895 into main Oct 31, 2024
@mikewoodward94
mikewoodward94 deleted the 93-git-check-will-always-return-dirty-repository branch October 31, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git check will always return dirty repository

2 participants