support comparators for Certus Quartz Tank - #349
Merged
Dream-Master merged 1 commit intoNov 15, 2025
Merged
Conversation
|
Give me a ping when this is ready please |
Dream-Master
added
the
🚧 Testing on Zeta
DarkShadow44
approved these changes
Nov 15, 2025
danyadev
added a commit
that referenced
this pull request
Nov 17, 2025
danyadev
added a commit
that referenced
this pull request
Nov 17, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #348 to be merged first as it depends on its
makeDirty()call in theupdatemethodReads only the tank connected to a comparator, doesn't include all tanks in a column
I tried to support columns, but I think it doesn't worth the effort, because it would require firing neighbor block updates for every tank in the column on every change in one of the tanks