certus quartz tank item rendering improvements - #355
Merged
Dream-Master merged 6 commits intoNov 9, 2025
Merged
Conversation
that way it simulated disabled GL_CULL_FACE for some reason. I changed it to actually disabling GL_CULL_FACE, so it renders the same, except that the bottom part is rendering the actual bottom side, not the top side
it makes the item render almost the same way as the block renders
sisyphussy
reviewed
Nov 8, 2025
Dream-Master
added
the
🚧 Testing on Zeta
sisyphussy
reviewed
Nov 9, 2025
sisyphussy
reviewed
Nov 9, 2025
danyadev
added a commit
that referenced
this pull request
Nov 17, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderItemcall. Previously it tried to simulateglDisable(GL_CULL_FACE), now I'm just calling it explicitly. Now the bottom side renders correctly: it uses the bottom texture instead of the top oneGL_BLENDfor the tank, left it on for the fluidGL_LIGHTINGfor the fluidChanged it because I didn't like the sides of the fluid having a shade, and after disabling
GL_LIGHTNINGthe tank became too dark compared to the fluid, so I disabledGL_BLENDtoo. Also now the item looks exactly the same as the blockBefore / After:
Before / After: (in both cases it had fluid, there were two separate bugs with its rendering)
