allow draining tank tower from an empty tank above - #359
Merged
boubou19 merged 6 commits intoDec 16, 2025
Conversation
Dream-Master
added
the
🚧 Testing on Zeta
|
Has there been discussion on whether we want this? I've always taking it for granted that you can't extract fluid that is under the level your pipe is connected. |
Member
Author
|
All other tanks (that support towering) work this way: bc tanks, iron tanks, openblocks tanks it just looks like it's mostly working: you can fill tanks from the top, you could see fluid in waila even when the tank is empty but one of the lower tanks isn't (I removed that in a previous pr during a refactor), the only thing you can't do is to drain from the top |
lc-1337
reviewed
Dec 16, 2025
lc-1337
approved these changes
Dec 16, 2025
boubou19
enabled auto-merge (squash)
December 16, 2025 19:06
Dream-Master
removed
the
🚧 Testing on Zeta
3 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can drain an empty tank above if there is fluid in one of the tanks below. Also Waila now shows full tower amount and capacity when hovering on empty or filled tanks. Also it now shows the capacity even if there's no fluid
drain.upper.tanks.mp4