Fix several offhand issues - #196
Merged
Merged
Conversation
…pecific items that cause issues
5 tasks
Caedis
approved these changes
Aug 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I wrote this 3 weeks ago with the intend to push it after my previous PR and I completely forgot about it.
That said giving it a test just now I found some edge cases to fix.
Hopefully should improve a bunch of things in the list here GTNewHorizons/GT-New-Horizons-Modpack#22178
Fix Interaction fall through
It should now handle properly: canceled right-click block interactions, server side main hand tool for which right click return false to the client, and a few more edge cases.
Added main hand fallback block list
This add a new config:
mainhandUseStopsOffhandFallbackThis doesn't stop using said items in offhand (there is already a config for that), but hard block any offhand interaction while they are in main hand due to having complicated handling
Default entries cover known problematic server-authoritative tools, including Matter Manipulator tiers, Forestry handheld GUIs/backpacks, Draconic Evolution item dislocator, and AE2 network tools.
Fix Thaumcraft vis orb pickup
Allow offhand wand to pickup vis orb
Checklist