[Memory-opti:fix leak] fix three world leaks - #32
Merged
Conversation
Alexdoru
changed the title
Alexdoru
changed the title
|
I can take a look tomorrow or so, if nobody else is faster |
|
Is there no performance benefit of caching here anymore? |
Member
Author
Caching what? |
|
The leaking code looks to be caching something in a thread local to minimize lookups, I just didn't see a comment as to why that wasn't valuable so asked |
Member
Author
chunk lookups are O(1) there is no need to cache anything |
Guvante
reviewed
May 5, 2026
Guvante
left a comment
Guvante
left a comment
There was a problem hiding this comment.
LGTM but had a few "is this code bugged" questions
Guvante
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr is a lot of automate code fixes, and the bug fix are actually 10 lines of code